Change dockerhub secret #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This organization has been deprecated for a while now. Based on usage stats from dockerhub, zero pulls have been performed since july/2024, so customers/community aren't pulling from this org anymore and thus is safe to stop publishing to it.
Change the secret being fetched by a new one that is named following our secret naming guidelines In addition, remove hard-coded username to allow easy change in the future of this value
andrewhsu
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change secret for dockerhub so that the workflow stops using
sdlc/prod/github/dockerhub_tokenand instead usessdlc/prod/github/dockerhub, as this new secret allows to reference other values that comply with the naming guidelineof our company security guidelines.
The publishing of containers to
vectorizedorg is also removed in this PR since that is not used by anyone anymore.